fix: Skip schema inference when prompt template doesn't reference schema #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…hema
When a custom prompt_template is provided that doesn't contain any
Mustache references to {{schema}}, the expensive get_schema() call
(which runs full table scans for column statistics) is now skipped
entirely. This allows users with large databases to avoid the slow
startup by providing their own prompt template without {{schema}}.
Uses a regex to detect schema references in any Mustache form:
{{schema}}, {{{schema}}}, {{#schema}}, {{^schema}}.
Closes #208
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cpsievert
force-pushed
the
feature/system-prompt-override
branch
from
a7bc7fb to
ec088ab
Compare
cpsievert
changed the title
cpsievert
changed the title
gadenbuie
approved these changes
Feb 11, 2026
Contributor
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
It's nice that this approach works the same way in Python and R 😄
The ruff PLW0108 lint error (unnecessary lambda) in test_base.py was causing format checks to fail. The griffe 2.0.0 release broke quartodoc 0.11.1's docstring parsing, so pin griffe<2 until quartodoc adds support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thank you for the quick change, this works for me now. Appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prompt_templateis provided that doesn't contain Mustache references to{{schema}}, the expensiveget_schema()call is now skipped entirelyprompt_templateparameterCloses #208
How it works
In
QueryChatSystemPrompt.__init__()(both R and Python), a regex check detects whether the template referencesschemaas a Mustache variable in any form ({{schema}},{{{schema}}},{{#schema}},{{^schema}}). If not found,get_schema()is never called andschemais set to an empty string.Usage
🤖 Generated with Claude Code